Merge pull request #601 from Vadaski/master

remove useless code in boost_page_route

lib/container/boost_page_route.dart

@@ -21,6 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
+
 import 'package:flutter/widgets.dart';
 import 'package:flutter/material.dart';
 
@@ -36,23 +37,14 @@ class BoostPageRoute<T> extends MaterialPageRoute<T> {
 
   final Set<VoidCallback> backPressedListeners = Set<VoidCallback>();
 
-  @override
-  Widget buildTransitions(BuildContext context, Animation<double> animation,
-      Animation<double> secondaryAnimation, Widget child) {
-    return super.buildTransitions(context, animation, secondaryAnimation, child);
-  }
-
   BoostPageRoute(
-      {Key stubKey,
-      this.pageName,
+      {this.pageName,
       this.params,
       this.uniqueId,
       this.animated,
       this.builder,
       this.settings})
-      : super(
-            builder: (BuildContext context) => Stub(stubKey, builder(context)),
-            settings: settings);
+      : super(builder: builder, settings: settings);
 
   static BoostPageRoute<T> of<T>(BuildContext context) {
     final Route<T> route = ModalRoute.of(context);
@@ -72,18 +64,3 @@ class BoostPageRoute<T> extends MaterialPageRoute<T> {
     }
   }
 }
-
-@immutable
-class Stub extends StatefulWidget {
-  final Widget child;
-
-  const Stub(Key key, this.child) : super(key: key);
-
-  @override
-  _StubState createState() => _StubState();
-}
-
-class _StubState extends State<Stub> {
-  @override
-  Widget build(BuildContext context) => widget.child;
-}

test/lib/unit/boost_page_route_test.dart

@@ -44,4 +44,131 @@ void main() {
     expect(find.text('Page 1'), findsNothing);
     expect(find.text('Page 2'), isOnstage);
   });
+
+  group('Try to get the BoostPageRoute in the ancestor node', () {
+    testWidgets(
+        'obtain BoostPageRoute through the `BoostPageRoute.of(context)` method',
+        (WidgetTester tester) async {
+      var boostPageRoute;
+      var boostPageRouteFindByOfMethod;
+
+      await tester.pumpWidget(
+        MaterialApp(
+          onGenerateRoute: (RouteSettings settings) {
+            boostPageRoute = BoostPageRoute<void>(
+              settings: settings,
+              builder: (BuildContext context) => Builder(
+                builder: (context) {
+                  return FloatingActionButton(
+                    onPressed: () {
+                      boostPageRouteFindByOfMethod = BoostPageRoute.of(context);
+                    },
+                  );
+                },
+              ),
+            );
+            return boostPageRoute;
+          },
+        ),
+      );
+
+      await tester.tap(find.byType(FloatingActionButton));
+
+      // The route obtained from the ancestor node through the `of` method should be the same BoostPageRoute
+      // as the originally created BoostPageRoute
+      expect(boostPageRoute, boostPageRouteFindByOfMethod);
+    });
+
+    testWidgets(
+        'try to find BoostPageRoute through the `BoostPageRoute.of(context)` method, '
+        'but it doesn\'t exist, the method should throw an Exception',
+        (WidgetTester tester) async {
+      var contextCache;
+
+      await tester.pumpWidget(
+        MaterialApp(
+          onGenerateRoute: (RouteSettings settings) {
+            return MaterialPageRoute(
+              settings: settings,
+              builder: (context) => Builder(
+                builder: (context) => FloatingActionButton(
+                  onPressed: () {
+                    contextCache = context;
+                  },
+                ),
+              ),
+            );
+          },
+        ),
+      );
+      await tester.tap(find.byType(FloatingActionButton));
+
+      expect(() => BoostPageRoute.of(contextCache), throwsException);
+    });
+
+    testWidgets(
+        'obtain BoostPageRoute through the `BoostPageRoute.tryOf(context)` method',
+        (WidgetTester tester) async {
+      var boostPageRoute;
+      var boostPageRouteFindByOfMethod;
+
+      await tester.pumpWidget(
+        MaterialApp(
+          onGenerateRoute: (RouteSettings settings) {
+            boostPageRoute = BoostPageRoute<void>(
+              settings: settings,
+              builder: (BuildContext context) => Builder(
+                builder: (context) {
+                  return FloatingActionButton(
+                    onPressed: () {
+                      boostPageRouteFindByOfMethod =
+                          BoostPageRoute.tryOf(context);
+                    },
+                  );
+                },
+              ),
+            );
+            return boostPageRoute;
+          },
+        ),
+      );
+
+      await tester.tap(find.byType(FloatingActionButton));
+
+      // The route obtained from the ancestor node through the `tryOf` method should be the same BoostPageRoute
+      // as the originally created BoostPageRoute
+      expect(boostPageRoute, boostPageRouteFindByOfMethod);
+    });
+  });
+
+  testWidgets(
+      'try to find BoostPageRoute through the `BoostPageRoute.tryOf(context)` method, '
+      'but it doesn\'t exist, the method should return null',
+      (WidgetTester tester) async {
+    var boostPageRouteFindByOfMethod;
+
+    await tester.pumpWidget(
+      MaterialApp(
+        onGenerateRoute: (RouteSettings settings) {
+          return MaterialPageRoute(
+            settings: settings,
+            builder: (BuildContext context) => Builder(
+              builder: (context) {
+                return FloatingActionButton(
+                  onPressed: () {
+                    boostPageRouteFindByOfMethod =
+                        BoostPageRoute.tryOf(context);
+                  },
+                );
+              },
+            ),
+          );
+        },
+      ),
+    );
+
+    await tester.tap(find.byType(FloatingActionButton));
+
+    expect(boostPageRouteFindByOfMethod, null);
+  });
 }